Skip to content

Improve settings implementation #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Feb 28, 2017
Merged

Improve settings implementation #717

merged 29 commits into from
Feb 28, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Feb 24, 2017

Tasks to finish

  • Add tests for parsing of int and bool type from settings file
  • Localize strings
  • Update changelog

Kapil Borle added 24 commits February 16, 2017 13:55
Currently, we can provide either a PowerShell data file or a
hashtable to the settings parameter. But we would like users to
take advantage of the builtin setting files {PSGallery,DSC,etc}
by providing only their names as values. This provides a easier
way to use these builtin setting files.
Ideally we should use HashtableAst.SafeGetValue() but that API is available only on PSv4 and onwards. As we support PSv3, we need our own implementation. And since we do not want any discrepancy in behavior across different PS versions, we use this custom implementation for all PS versions.
Kapil Borle added 4 commits February 23, 2017 19:22
Also changes the namespace from `Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.Settings` to `Microsoft.Windows.PowerShell.ScriptAnalyzer.Settings`.
@kapilmb kapilmb changed the title [WIP] Improve settings implementation Improve settings implementation Feb 28, 2017
@daviwil
Copy link
Contributor

daviwil commented Feb 28, 2017

This is great! Looks good to me.

@kapilmb
Copy link
Author

kapilmb commented Feb 28, 2017

@daviwil Thanks!

@kapilmb kapilmb merged commit 1987389 into development Feb 28, 2017
@kapilmb kapilmb deleted the kapilmb/settings branch February 28, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants